Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentracing-cpp: 1.5.1 -> 1.6.0 #104567

Merged
merged 1 commit into from Oct 19, 2023
Merged

opentracing-cpp: 1.5.1 -> 1.6.0 #104567

merged 1 commit into from Oct 19, 2023

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/opentracing/opentracing-cpp/releases.

meta.description for opentracing-cpp is: "C++ implementation of the OpenTracing API"

meta.homepage for opentracing-cpp is: "https://opentracing.io"

meta.changelog for opentracing-cpp is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
lightstep-tracer-cpp
opentracing-cpp
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/7fp174pp3cpijmk5jwa61ymkbjr6qjax-opentracing-cpp-1.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A opentracing-cpp https://github.com/r-ryantm/nixpkgs/archive/9014113a103faffe2284ac96a238c7873777e7ab.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/7fp174pp3cpijmk5jwa61ymkbjr6qjax-opentracing-cpp-1.6.0
ls -la /nix/store/7fp174pp3cpijmk5jwa61ymkbjr6qjax-opentracing-cpp-1.6.0/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package failed to build:
  • lightstep-tracer-cpp
1 package built:
  • opentracing-cpp
Maintainer pings

cc @rbvermaa for testing.

@ofborg ofborg bot requested a review from rbvermaa November 22, 2020 07:29
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104567 run on x86_64-linux 1

1 package failed to build and are new build failure:
1 package built:
  • opentracing-cpp

@lukegb
Copy link
Contributor

lukegb commented May 2, 2021

Still blocked on lightstep-tracer-cpp switching to the 1.6.x OpenTracing release.

@Artturin Artturin marked this pull request as draft August 10, 2021 00:04
@Lassulus
Copy link
Member

Still blocked on lightstep-tracer-cpp switching to the 1.6.x OpenTracing release.

any progress on that? should we close this?

@applePrincess
Copy link
Contributor

looks like no updates for 3 years: lightstep/lightstep-tracer-cpp#215

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2022
@AndersonTorres
Copy link
Member

looks like no updates for 3 years: lightstep/lightstep-tracer-cpp#215

lightstep/lightstep-tracer-cpp@0dcb916

❗ This instrumentation is no longer recommended. Please review documentation on setting up and configuring the OpenTelemetry C++ API and SDK for more information on migrating to updated instrumentation.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 18, 2023
@applePrincess
Copy link
Contributor

Oh I just missed that commit. So can we maintain two versions of opentracing-cpp, 1.6.0 (or newer if any) and 1.5.1 for lightstep-tracer-cpp or mark lightstep-tracer-cpp broken (Perhaps this is a more aggressive option, but remove lightstep-tracer-cpp since it seems as if the package is not referenced by any other packages in this repository)?

@AndersonTorres
Copy link
Member

The problem is way worse:

Opentracing was essentially abandoned.
It makes few to no sense to keep it.

However, too many files inside Nixpkgs depend on it. I am trying to remove some of them, but others are machine-generated.

@AndersonTorres AndersonTorres mentioned this pull request Oct 18, 2023
Merged
12 tasks
@AndersonTorres AndersonTorres marked this pull request as ready for review October 19, 2023 03:13
@AndersonTorres
Copy link
Member

Since this package is now rendered useless, I will merge it just because.

@AndersonTorres
Copy link
Member

@ofborg build opentracing-cpp

@AndersonTorres AndersonTorres merged commit 2001590 into NixOS:master Oct 19, 2023
3 of 4 checks passed
@r-ryantm r-ryantm deleted the auto-update/opentracing-cpp branch October 19, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbvermaa rbvermaa Awaiting requested review from rbvermaa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r-ryantm @SuperSandro2000 @lukegb @Lassulus @applePrincess @AndersonTorres