ghostscript: fix broken rpath on Darwin #104593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg eval |
veprbl
reviewed
Nov 23, 2020
siriobalmelli
force-pushed
the
fix/ghostscript
branch
from
b7c6278
to
084dc17
Compare
|
@veprbl thank you for help cleaning this up. Re-rolled as a single commit and force-pushed. |
veprbl
reviewed
Nov 24, 2020
Dynamic library name on Darwin contains only 'maj.min' eg "9.53"; the build however used $version to set rpath; this broke on 2029ca3 when $version went from "9.52" to "9.53.3". Add a call to 'gs' in installCheckPhase, to break the build if dylib issues arise in the future. Signed-off-by: Sirio Balmelli <sirio@b-ad.ch> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
siriobalmelli
force-pushed
the
fix/ghostscript
branch
from
084dc17
to
a775974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic library name on Darwin contains only 'maj.min' eg "9.53";
the build however used $version to set rpath;
this broke on 2029ca3 when $version went from "9.52" to "9.53.3".
Signed-off-by: Sirio Balmelli sirio@b-ad.ch