Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.shapely: Set minimum python version to 3.5 #104605

Merged
merged 1 commit into from Nov 24, 2020

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Nov 22, 2020

Motivation for this change

The python package shapely only works on python versions newer than 3.5. This PR addresses this fact.

For reference see https://github.com/Toblerity/Shapely/blob/master/setup.py#L193

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seppeljordan
Copy link
Contributor Author

Result of nixpkgs-review pr 104605 1

@symphorien symphorien merged commit b32a284 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants