Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: support more than one CDN url #37

Merged
merged 1 commit into from Nov 22, 2020

Conversation

TrueBrain
Copy link
Member

This is useful to distribute load/cost over multiple servers.

This is useful to distribute load/cost over multiple servers.
@TrueBrain
Copy link
Member Author

@LordAro @frosch123 : could either of you review this? Cheers!

bananas_server/web_routes.py Show resolved Hide resolved
async def check_cdn_health():
await asyncio.sleep(1)

log.info("Healthchecks for CDN servers %r enabled", CDN_URL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%r ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, %r. CDN_URL is a list or None, so using __repr__ gives the best readable result, without doing complex things. Not sure what your question is here honestly :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just didn't recognise it

@TrueBrain TrueBrain merged commit d12b5b3 into OpenTTD:master Nov 22, 2020
@TrueBrain TrueBrain deleted the vps_support branch November 22, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants