Add pgweb, a light and fast web-based PostgreSQL database browser #104597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My first real PR to nixpkgs so be gentle :). I'm not sure how to do the checklist items from the PR template, nor which even apply to such a PR. |
domenkozar
reviewed
Nov 22, 2020
|
Would be nice to add a Welcome on board 👋 |
RaghavSood
reviewed
Nov 22, 2020
SuperSandro2000
requested changes
Nov 22, 2020
Add pgweb, a light and fast web-based PostgreSQL database browser
zupo
commented
Nov 22, 2020
| @@ -0,0 +1,26 @@ | |||
| { buildGoPackage, fetchFromGitHub, lib }: | |||
There was a problem hiding this comment.
A question: is lib required here? If yes, is maintainers required too? If not, why not?
There was a problem hiding this comment.
lib is exposed as a top-level "package" so injection will work for it, maintainers, platforms and so on are nested fields, so they can't be injected by callPackage.
So yes you inject lib, and then you use it to build the meta field (and potentially to call other functions)
There was a problem hiding this comment.
So it's good like it is now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Pgweb is a light & fast browser-based PostgreSQL browser that I have been using for years. Recently I moved from homebrew to darwin-nixos and added the code from this PR into my
configuration.nixfile. Then came the realization that I could/should upstream it! So here we are.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)