Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u9fs: 20110513 -> unstable-2020-11-21 #104576

Merged
merged 1 commit into from Nov 22, 2020
Merged

u9fs: 20110513 -> unstable-2020-11-21 #104576

merged 1 commit into from Nov 22, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Nov 22, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Nov 22, 2020

Result of nixpkgs-review pr 104576 1

1 package built:
  • u9fs

SuperSandro2000
SuperSandro2000 reviewed Nov 22, 2020
View reviewed changes
pkgs/servers/u9fs/default.nix Show resolved Hide resolved
pkgs/servers/u9fs/default.nix
description = "Serve 9P from Unix";
homepage = "http://plan9.bell-labs.com/magic/man2html/4/u9fs";
license = licenses.free;
maintainers = [ maintainers.ehmry ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = [ maintainers.ehmry ];
maintainers = with maintainers; [ ehmry ];

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this preferred?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes changing maintainers easier. I prefer it.

@SuperSandro2000
Copy link
Member

@ehmry because ofborg is having problems.

@ehmry ehmry merged commit 8a4cf08 into NixOS:master Nov 22, 2020
@siraben siraben deleted the u9fs-update branch November 22, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @SuperSandro2000 @ehmry