Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yed: unmark broken #104572

Merged
merged 1 commit into from Nov 26, 2020
Merged

yed: unmark broken #104572

merged 1 commit into from Nov 26, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 22, 2020 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 22, 2020
@doronbehar
Copy link
Contributor

It's good now, only the commit message should be rewritten. Because this is not going to be a achange in the content of the commit I suspect GitHub won't notify me upon your force push, so please notify me when that's done.

doronbehar
doronbehar reviewed Nov 23, 2020
View reviewed changes
pkgs/development/compilers/openjdk/darwin/default.nix Outdated
@@ -50,6 +50,7 @@ let

passthru = {
home = jdk;
inherit gtk3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and please add a comment here explaining the situation, and indicating that gtk3 is not an input of this package.

@r-burns r-burns mentioned this pull request Nov 23, 2020
Merged
10 tasks
@veprbl
Copy link
Member

veprbl commented Nov 23, 2020

Adding gtk3 to jre.passthru does not fix yed on darwin, right?

@r-burns
Copy link
Contributor Author

r-burns commented Nov 24, 2020

@doronbehar Let me know if that's more what you had in mind

@r-burns
Copy link
Contributor Author

r-burns commented Nov 24, 2020

@veprbl I don't use yed but as far as I can tell I'm able to run the application and basic stuff seems to work

@veprbl
Copy link
Member

veprbl commented Nov 24, 2020

@veprbl I don't use yed but as far as I can tell I'm able to run the application and basic stuff seems to work

Then we could unset yed.meta.broken and be done with it.

@r-burns
Copy link
Contributor Author

r-burns commented Nov 24, 2020

D'oh, you are right. I don't know why I didn't realize that.

@r-burns r-burns changed the title yed: fix eval on darwin yed: unmark broken Nov 24, 2020
@doronbehar
Copy link
Contributor

I don't understand what is the conclusion reached.

@r-burns
Copy link
Contributor Author

r-burns commented Nov 24, 2020

Apparently the gtk3 input isn't needed on darwin, if I unmark it as broken it just works 🤷

@veprbl
Copy link
Member

veprbl commented Nov 24, 2020

Probably the gtk3 dependency is optional. I would guess it's used to provide a system file chooser dialog and the rest is done using some java libraries.

@doronbehar
Copy link
Contributor

Oh so this is a revert of 91e1cc1 by @veprbl . Yea sure this LGTM. I didn't know about it and I remembered the expression to be different.

@Lassulus Lassulus merged commit 9301794 into NixOS:master Nov 26, 2020
@r-burns r-burns deleted the yed branch November 26, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@doronbehar doronbehar doronbehar left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-burns @doronbehar @veprbl @SuperSandro2000 @Lassulus