Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perldevel: 5.33.3 -> 5.33.4, perl-cross: 65e06e2 -> 6c11560 #104607

Merged
merged 1 commit into from Nov 23, 2020
Merged

perldevel: 5.33.3 -> 5.33.4, perl-cross: 65e06e2 -> 6c11560 #104607

merged 1 commit into from Nov 23, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 22, 2020 •
edited

Motivation for this change

https://metacpan.org/changes/release/TOMHUKINS/perl-5.33.4

dependencies:
perl-cross: arsv/perl-cross@65e06e2 -> arsv/perl-cross@6c11560

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested OK on linux x64 and darwin x64

Result of nixpkgs-review pr 104607 1

1 package built:
  • perldevel

@stigtsp stigtsp requested a review from volth November 22, 2020 14:26
@stigtsp stigtsp marked this pull request as draft November 22, 2020 14:26
@stigtsp stigtsp changed the title [WIP] perldevel: 5.33.3 -> 5.33.4 [WIP] perldevel: 5.33.3 -> 5.33.4, perl-cross: 65e06e2 -> 97400c8 Nov 22, 2020
@ofborg ofborg bot requested a review from edolstra November 22, 2020 14:42
@stigtsp
perldevel: 5.33.3 -> 5.33.4
408236c 
dependencies:
perl-cross: 65e06e238ccb949e8399bdebc6d7fd798c34127b -> 6c115604fcbf01ceb3c6d7c13206a7590abf6c21
@stigtsp stigtsp changed the title [WIP] perldevel: 5.33.3 -> 5.33.4, perl-cross: 65e06e2 -> 97400c8 perldevel: 5.33.3 -> 5.33.4, perl-cross: 65e06e2 -> 6c11560 Nov 23, 2020
@stigtsp stigtsp marked this pull request as ready for review November 23, 2020 01:03
@stigtsp
Copy link
Member Author

stigtsp commented Nov 23, 2020

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perldevel
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perldevel
@GrahamcOfBorg build pkgsMusl.perldevel
@GrahamcOfBorg build pkgsi686Linux.perldevel
@GrahamcOfBorg build perldevel

Cross non-devel perl:
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perl

@stigtsp stigtsp merged commit b0fa828 into NixOS:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@aanderse aanderse Awaiting requested review from aanderse

@lopsided98 lopsided98 Awaiting requested review from lopsided98

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@stigtsp