Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packet-sd: enable build on unix #104604

Merged
merged 1 commit into from Dec 16, 2020
Merged

packet-sd: enable build on unix #104604

merged 1 commit into from Dec 16, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Nov 22, 2020 •
edited

Motivation for this change

It builds on darwin as well so no need to restrict it to linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and andir November 22, 2020 14:16
@andir
Copy link
Member

andir commented Nov 22, 2020

Can you add a motivation on this PR and the commit? Why is this required / a good idea?

@siraben
Copy link
Member Author

siraben commented Nov 22, 2020

Updated.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104604 run on x86_64-darwin 1

1 package built:
  • packet-sd

@andir
Copy link
Member

andir commented Nov 22, 2020 via email

@siraben
Copy link
Member Author

siraben commented Nov 23, 2020

@andir I'm not sure I understand. I've read the guide and have done similar commits in the past.

@doronbehar
Copy link
Contributor

The commit message looks good to me. It's also fairly trivial to figure out why someone would add more platforms to a meta of a drv - it works there and they want to use it.

@doronbehar doronbehar merged commit 1048a1e into NixOS:master Dec 16, 2020
@siraben siraben deleted the packet-sd-darwin branch December 17, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siraben @andir @SuperSandro2000 @doronbehar