Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dino: 0.1.0 -> 0.2.0 #103626

Merged
merged 1 commit into from Nov 12, 2020
Merged

dino: 0.1.0 -> 0.2.0 #103626

merged 1 commit into from Nov 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2020 •
edited by ghost

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from alyssais and Mic92 November 12, 2020 17:17
@ghost
Copy link
Author

ghost commented Nov 12, 2020

@GrahamcOfBorg build dino

@mweinelt
Copy link
Member

mweinelt commented Nov 12, 2020 •
edited

https://github.com/dino/dino/releases/tag/v0.2.0 😄
https://dino.im/blog/2020/11/dino-0.2-release/

@ghost
Copy link
Author

ghost commented Nov 12, 2020

@GrahamcOfBorg eval

@ghost ghost changed the title dino: 0.1.0 -> 0.1.1 dino: 0.1.0 -> 0.2.0 Nov 12, 2020
@picnoir
Copy link
Member

picnoir commented Nov 12, 2020

I just manually tested that. I couldn't spot any obvious regression. Let's wait for ofborg, but 👍 I guess.

@mweinelt
Copy link
Member

Looks good here as well.

Result of nixpkgs-review pr 103626 1

1 package built:
  • dino

@mweinelt mweinelt merged commit a245f37 into NixOS:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @picnoir