Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makemkv: 1.15.2 -> 1.15.3 #103639

Merged
merged 1 commit into from Nov 12, 2020
Merged

makemkv: 1.15.2 -> 1.15.3 #103639

merged 1 commit into from Nov 12, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog (summarized):

  • Massive internanal rewrite.
  • Improved handling of disks with mastering errors.
  • MakeMKV now can extract Dolby Vision metadata from elementary stream
    data.
  • MakeMKV now forces low speed when reading data around disc edges,
    working around firmware bugs
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
makemkv: 1.15.2 -> 1.15.3
c80ddf3 
Changelog (summarized):

- Massive internanal rewrite.
- Improved handling of disks with mastering errors.
- MakeMKV now can extract Dolby Vision metadata from elementary stream
  data.
- MakeMKV now forces low speed when reading data around disc edges,
  working around firmware bugs
@ofborg ofborg bot requested a review from titanous November 12, 2020 19:37
@picnoir
Copy link
Member

picnoir commented Nov 12, 2020

Result of nixpkgs-review pr 103639 1

1 package built:
  • makemkv

@danieldk danieldk merged commit e220cc0 into NixOS:master Nov 12, 2020
@danieldk danieldk deleted the makemkv-1.15.3 branch November 12, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titanous titanous titanous approved these changes

@picnoir picnoir picnoir approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @picnoir @titanous