Skip to content

turbo-geth: 2020.11.01 -> 2020.1.02 #103605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2020
Merged

turbo-geth: 2020.11.01 -> 2020.1.02 #103605

merged 1 commit into from
Nov 14, 2020
+3 −3

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented Nov 12, 2020

Motivation for this change

New release: https://github.com/ledgerwatch/turbo-geth/releases/tag/v2020.11.02

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@d-xo d-xo requested a review from mmahut as a code owner November 12, 2020 12:50
@d-xo d-xo requested a review from doronbehar November 12, 2020 12:50
@ofborg ofborg bot requested a review from kalbasit November 12, 2020 13:03
prusnak
prusnak requested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the commit message

@d-xo
turbo-geth: 2020.11.01 -> 2020.11.02

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: A0E01EF44C27BF00
Learn about vigilant mode
08ca1ee
@d-xo d-xo force-pushed the turbo-geth-2020-11-02 branch from 38054cc to 08ca1ee Compare November 13, 2020 12:57
@d-xo
Copy link
Contributor Author

d-xo commented Nov 13, 2020

fixed, thanks!

@doronbehar doronbehar merged commit 4fe31b0 into NixOS:master Nov 14, 2020
@d-xo d-xo deleted the turbo-geth-2020-11-02 branch November 14, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak

@doronbehar doronbehar

@mmahut mmahut

@kalbasit kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-xo @prusnak @doronbehar