[20.09] backport of graalvm{8,11}-ce, babashka clj kondo #103598
Merged
+183
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 674c9af)
Now that we have community builds of graalvm landed in NixOS#99631, both clj-kondo and babashka can depend on those versions of graalvm rather than the one that requires building from source - this can be built in hydra, and generally is much easier to build and test. (cherry picked from commit 3341f6c)
with NixOS#99631 and NixOS#102693 merged, it's possible to bump the babashka version again. However recent versions of babashka depend on java11 features and I spoke in Slack with the project lead and this java11 dependency will exist going forward. (cherry picked from commit 172cbb8)
(cherry picked from commit 045c2ab)
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
marvin-mk2
bot
added
marvin
bennyandresen
changed the title
ofborg
bot
added
8.has: clean-up
8.has: package (new)
marvin-mk2
bot
added
awaiting_reviewer
ofborg
bot
added
10.rebuild-darwin: 0
glittershark
approved these changes
Nov 12, 2020
|
/status needs_merger |
|
The PR author cannot set the status to If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
/status needs_merger |
marvin-mk2
bot
added
needs_merger
marvin-mk2
bot
added
awaiting_merger
timokau
requested changes
Nov 13, 2020
marvin-mk2
bot
added
awaiting_changes
marvin-mk2
bot
added
awaiting_reviewer
timokau
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Thank you, and thanks @glittershark for the initial review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
clj-kondo and babashka is currently broken on 20.09 and this fixed it
cherry-picked from, PR and message
674c9af #99631 graalvm{8,11}-ce: init at 20.2.0
3341f6c #102693 babashka,clj-kondo: Depend on graalvm-ce
172cbb8 #102867 babashka: 0.0.97 -> 0.2.3
045c2ab #103096 clj-kondo: 2020.04.05 -> 2020.11.07
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)/marvin opt-in
/status needs_reviewer
cc: @jonringer @glittershark