Remove ResponseWriter.flush() and explicit_flush #26500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reliable way to detect aliveness of a socket is to check wfile.write(). flush() is either not necessary (in Python 2) or non-functional (in Python 3), and should be removed for clarity. Detailed explaination can be found at: web-platform-tests#24719
wpt-pr-bot
requested review from
annevk,
asutherland,
caitp,
domenic,
foolip,
Hexcles,
jdm,
jgraham,
LukeZielinski,
Manishearth,
mkruisselbrink,
npm1,
odinho,
stephenmcgruer and
wanderview
ziransun
changed the title
wpt-pr-bot
requested review from
igrigorik,
plehegar,
wisniewskit,
Yaffle,
yoavweiss and
zqzhang
and removed request for
npm1 and
LukeZielinski
ziransun
changed the title
ziransun
changed the title
|
Is this still WIP? Or do you want me to take a look as is? |
ziransun
changed the title
@Hexcles: It's ready for review :). |
Hexcles
reviewed
Nov 16, 2020
|
@Hexcles : Code updated. Thank you! |
jgraham
reviewed
Nov 17, 2020
| @@ -4,7 +4,6 @@ def main(request, response): | |||
| response.headers.set(b'Content-Type', b'text/event-stream') | |||
| response.headers.set(b'Cache-Control', b'no-cache') | |||
|
|
|||
| response.explicit_flush = True | |||
There was a problem hiding this comment.
So it sems lke these tests using explicit_flush might be broken? Should we replace this with a mechanism that works in the way they expect (or otherwise edit the tests to call write once)?
There was a problem hiding this comment.
Yes and no.
They have always been broken in the sense that flush and explicit_flush do not do what they expect. But in practice, they seem to only require content to be flushed out before sleep, and unbuffered write satisfies that, which also explains why no test result changes.
There was a problem hiding this comment.
I'm merging this for now. Feel free to open a new issue on this if you think it's important.
pull bot
pushed a commit
to Yannic/chromium
that referenced
this pull request
Nov 27, 2020
The most significant change was web-platform-tests/wpt#26500 Change-Id: Ic057ff627d6c0887e8935192609f94b3fd767762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562226 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#831421}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The most significant change was web-platform-tests/wpt#26500 Change-Id: Ic057ff627d6c0887e8935192609f94b3fd767762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562226 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#831421} GitOrigin-RevId: 97f4a1f6256d23980f7e8e317ffebfa63e2952a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reliable way to detect aliveness of a socket is to check
wfile.write(). flush() is either not necessary (in Python 2)
or non-functional (in Python 3), and should be removed for clarity.
Detailed explaination can be found at:
#24719