New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform-providers.gitlab: 2.9.0 -> 3.1.0 #103632
Conversation
1aadb8f
to
73d78e8
Compare
/tmp/gitlab-provider
❯ cat versions.tf
terraform {
required_providers {
gitlab = {
source = "gitlabhq/gitlab"
version = "3.1.0"
}
}
}
/tmp/gitlab-provider
❯ nix-shell -I nixpkgs=$HOME/Sources/GitHub/nixpkgs -p 'terraform_0_13.withPlugins (p: with p; [gitlab])' --command "terraform init" <<<
Initializing the backend...
Initializing provider plugins...
- Finding gitlabhq/gitlab versions matching "3.1.0"...
- Installing gitlabhq/gitlab v3.1.0...
- Installed gitlabhq/gitlab v3.1.0 (unauthenticated)
Terraform has been successfully initialized!
You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.
If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
/tmp/gitlab-provider
❯ cat .terraform/plugins/selections.json
{
"registry.terraform.io/gitlabhq/gitlab": {
"hash": "h1:kxiwFkz+/Qs6hk8c0APZtk24I+8eIRwwxaYm2P+uCp4=",
"version": "3.1.0"
}
}%
/tmp/gitlab-provider
❯ ls -alh .terraform/plugins/registry.terraform.io/gitlabhq/gitlab/3.1.0/linux_amd64
lrwxrwxrwx 1 sevenfourk users 124 Nov 13 09:47 .terraform/plugins/registry.terraform.io/gitlabhq/gitlab/3.1.0/linux_amd64 -> /nix/store/mf8bmly8iyhrcak0j4iqykh3jzq6fm36-terraform-0.13.5/plugins/registry.terraform.io/gitlabhq/gitlab/3.1.0/linux_amd64
/tmp/gitlab-provider
❯ |
❯ nixpkgs-review pr 103632
[nix-shell:~/.cache/nixpkgs-review/pr-103632-1]$ cat > versions.tf << EOF
> terraform {
> required_providers {
> gitlab = {
> source = "gitlabhq/gitlab"
> version = "3.1.0"
> }
> }
> }
> EOF
[nix-shell:~/.cache/nixpkgs-review/pr-103632-1]$ terraform
terraform terraform-provider-gitlab_v3.1.0
[nix-shell:~/.cache/nixpkgs-review/pr-103632-1]$ terraform init
Initializing the backend...
Initializing provider plugins...
- Finding gitlabhq/gitlab versions matching "3.1.0"...
- Installing gitlabhq/gitlab v3.1.0...
- Installed gitlabhq/gitlab v3.1.0 (unauthenticated)
Terraform has been successfully initialized!
You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.
If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
[nix-shell:~/.cache/nixpkgs-review/pr-103632-1]$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent ✔️. Thank you for your contribution.
terraform init
Initializing the backend...
Initializing provider plugins...
- Finding gitlabhq/gitlab versions matching "3.1.0"...
- Installing gitlabhq/gitlab v3.1.0...
- Installed gitlabhq/gitlab v3.1.0 (unauthenticated)
Terraform has been successfully initialized!
Other than backports, PR's should go to the
And then changing the base branch in the GitHub UI (see the |
73d78e8
to
069f183
Compare
@infinisil should be good, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks!
Motivation for this change
terraform-provider: gitlab version update to v3.1.0
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Guys, I'm fairly new to NixOS and to that terraform packaging as well, how would I get new sha256 for new gitlab provider version? Thanks.
update: i think i figured that ^ out.