Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-providers.gitlab: 2.9.0 -> 3.1.0 #103632

Merged
merged 1 commit into from Nov 25, 2020

Conversation

ivankovnatsky
Copy link
Contributor

@ivankovnatsky ivankovnatsky commented Nov 12, 2020

Motivation for this change

terraform-provider: gitlab version update to v3.1.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Guys, I'm fairly new to NixOS and to that terraform packaging as well, how would I get new sha256 for new gitlab provider version? Thanks.

update: i think i figured that ^ out.

@ivankovnatsky ivankovnatsky changed the title terraform-providers: gitlab version update to 3.1.0 terraform-providers.gitlab: 2.9.0 -> 3.1.0 Nov 13, 2020
@ivankovnatsky
Copy link
Contributor Author

/tmp/gitlab-providercat versions.tf
terraform {
  required_providers {
    gitlab = {
      source  = "gitlabhq/gitlab"
      version = "3.1.0"
    }
  }
}

/tmp/gitlab-providernix-shell -I nixpkgs=$HOME/Sources/GitHub/nixpkgs -p 'terraform_0_13.withPlugins (p: with p; [gitlab])' --command "terraform init"                                                                                                       <<<

Initializing the backend...

Initializing provider plugins...
- Finding gitlabhq/gitlab versions matching "3.1.0"...
- Installing gitlabhq/gitlab v3.1.0...
- Installed gitlabhq/gitlab v3.1.0 (unauthenticated)

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

/tmp/gitlab-providercat .terraform/plugins/selections.json
{
  "registry.terraform.io/gitlabhq/gitlab": {
    "hash": "h1:kxiwFkz+/Qs6hk8c0APZtk24I+8eIRwwxaYm2P+uCp4=",
    "version": "3.1.0"
  }
}%

/tmp/gitlab-providerls -alh .terraform/plugins/registry.terraform.io/gitlabhq/gitlab/3.1.0/linux_amd64
lrwxrwxrwx 1 sevenfourk users 124 Nov 13 09:47 .terraform/plugins/registry.terraform.io/gitlabhq/gitlab/3.1.0/linux_amd64 -> /nix/store/mf8bmly8iyhrcak0j4iqykh3jzq6fm36-terraform-0.13.5/plugins/registry.terraform.io/gitlabhq/gitlab/3.1.0/linux_amd64

/tmp/gitlab-provider

@ivankovnatsky
Copy link
Contributor Author

ivankovnatsky commented Nov 13, 2020

nixpkgs-review pr 103632

[nix-shell:~/.cache/nixpkgs-review/pr-103632-1]$ cat > versions.tf << EOF
> terraform {
>   required_providers {
>     gitlab = {
>       source  = "gitlabhq/gitlab"
>       version = "3.1.0"
>     }
>   }
> }
> EOF

[nix-shell:~/.cache/nixpkgs-review/pr-103632-1]$ terraform
terraform                         terraform-provider-gitlab_v3.1.0

[nix-shell:~/.cache/nixpkgs-review/pr-103632-1]$ terraform init

Initializing the backend...

Initializing provider plugins...
- Finding gitlabhq/gitlab versions matching "3.1.0"...
- Installing gitlabhq/gitlab v3.1.0...
- Installed gitlabhq/gitlab v3.1.0 (unauthenticated)

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

[nix-shell:~/.cache/nixpkgs-review/pr-103632-1]$

Copy link
Contributor

@timstott timstott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent ✔️. Thank you for your contribution.

terraform init

Initializing the backend...

Initializing provider plugins...
- Finding gitlabhq/gitlab versions matching "3.1.0"...
- Installing gitlabhq/gitlab v3.1.0...
- Installed gitlabhq/gitlab v3.1.0 (unauthenticated)

Terraform has been successfully initialized!

@infinisil
Copy link
Member

Other than backports, PR's should go to the master branch, not nixos-unstable. Assuming that the nixpkgs remote is called upstream, you can change the branch without any noise with

git rebase --onto $(git merge-base upstream/nixos-unstable upstream/master) HEAD~1
git push -f

And then changing the base branch in the GitHub UI (see the Edit button at the top of this PR)

@ivankovnatsky ivankovnatsky changed the base branch from nixos-unstable to master November 20, 2020 13:16
@ivankovnatsky ivankovnatsky reopened this Nov 20, 2020
@ivankovnatsky
Copy link
Contributor Author

@infinisil should be good, please check.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@infinisil infinisil merged commit af3ed06 into NixOS:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants