Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuse-overlayfs: Propagate fuse3 #103608

Closed
wants to merge 1 commit into from
Closed

fuse-overlayfs: Propagate fuse3 #103608

wants to merge 1 commit into from

Conversation

akirak
Copy link
Contributor

@akirak akirak commented Nov 12, 2020 •
edited

Motivation for this change

Fix a dependency issue where a runtime dependency was added only as a build dependency.

fusermount3 is required at runtime for the package. Some non-NixOS systems such as Ubuntu 18.04 LTS have fuse2 and not fuse3, so you have to add fuse3 as a runtime dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

saschagrunert
saschagrunert approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akirak
Copy link
Contributor Author

akirak commented Nov 13, 2020

Both buildInputs and propagateBuildInputs seem to be necessary. Without buildInputs, it fails to build:

checking for fuse3 >= 3.2.1... no
configure: error: *** libfuse not found
builder for '/nix/store/jbsn5kasbdj96kk8njcmbhpdh53bc1p2-fuse-overlayfs-1.2.0.drv' failed with exit code 1
error: build of '/nix/store/jbsn5kasbdj96kk8njcmbhpdh53bc1p2-fuse-overlayfs-1.2.0.drv' failed

I've changed the commit.

@ofborg ofborg bot requested a review from saschagrunert November 13, 2020 01:03
@zowoq
Copy link
Contributor

zowoq commented Nov 13, 2020 •
edited

Some non-NixOS systems such as Ubuntu 18.04 LTS have fuse2 and not fuse3, so you have to add fuse3 as a runtime dependency.

Have you checked that this patch works on non-NixOS?

@akirak
Copy link
Contributor Author

akirak commented Nov 13, 2020 •
edited

Sorry, I think this was wrong, so I'll close this issue.

Have you checked that this patch works on non-NixOS?

It would be necessary to wrap the program to add fuse to PATH, but no other FUSE packages do that. Installing fuse using nix-env -i on Ubuntu 18.04 LTS worked.

@akirak akirak closed this Nov 13, 2020
@akirak akirak deleted the fuse-overlayfs-prop-fuse branch November 12, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@vdemeester vdemeester Awaiting requested review from vdemeester

@furrycatherder furrycatherder Awaiting requested review from furrycatherder

@zowoq zowoq Awaiting requested review from zowoq

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akirak @zowoq @saschagrunert