Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scribusUnstable: 1.5.5 -> 1.5.6.1 #103601

Merged
merged 1 commit into from Nov 17, 2020
Merged

scribusUnstable: 1.5.5 -> 1.5.6.1 #103601

merged 1 commit into from Nov 17, 2020

Conversation

erictapen
Copy link
Member

Motivation for this change

Release notes: https://wiki.scribus.net/canvas/1.5.6_Release

Currently keeping this as draft as Scribus shows a nasty startup error, reported here. It doesn't compromise functionality but is bad UX.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Kiwi November 12, 2020 12:28
@erictapen erictapen marked this pull request as ready for review November 13, 2020 12:41
@erictapen
Copy link
Member Author

erictapen commented Nov 13, 2020 •
edited

Patched the bug, so this is ready for review, @Kiwi

@Kiwi
Copy link
Member

Kiwi commented Nov 13, 2020

heh I was already looking at it. :D I can confirm the bug that was there is not there now!

I did notice this now though idk if it's our fault or theirs. The ICC errors showed up on a previous version too and from what I can tell is they have images with bad color profiles so not our fault (though might be related/dependent on/caused by specific Qt versions).

pathForIcon: Unable to load icon /nix/store/n6dn9xaxzk08zm1nmr7phq8qgcallbb4-scribus-1.5.6/share/scribus/icons/1_5_1/lab.png: File not found
pathForIcon: Unable to load icon /nix/store/n6dn9xaxzk08zm1nmr7phq8qgcallbb4-scribus-1.5.6/share/scribus/icons/1_5_1/spot.png: File not found
pathForIcon: Unable to load icon /nix/store/n6dn9xaxzk08zm1nmr7phq8qgcallbb4-scribus-1.5.6/share/scribus/icons/1_5_1/register.png: File not found
qt.gui.icc: Unsupported ICC profile class 70727472
qt.gui.icc: fromIccProfile: failed general sanity check
QPngHandler: Failed to parse ICC profile

@erictapen
Copy link
Member Author

Mh yeah I noticed these errors too, but decided not to act on it, as I probably don't want to go into that rabbit hole atm. I have little knowledge about color profiles and Qt.

So I'd vote for leaving this as it is for now.

@erictapen erictapen changed the title scribusUnstable: 1.5.5 -> 1.5.6 scribusUnstable: 1.5.5 -> 1.5.6.1 Nov 15, 2020
@erictapen
Copy link
Member Author

Bumped to 1.5.6.1, which makes the patch unnecessary.

Kiwi
Kiwi approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@Kiwi Kiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work! and one less thing I need python2 for!

@erictapen
Copy link
Member Author

Thanks for the review, @Kiwi , I'll merge it then.

@erictapen erictapen merged commit b605b98 into NixOS:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwi Kiwi Kiwi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erictapen @Kiwi