Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.wireguard: 1.0.20200908 -> 1.0.20201112 #103600

Merged
merged 1 commit into from Nov 12, 2020
Merged

linuxPackages.wireguard: 1.0.20200908 -> 1.0.20201112 #103600

merged 1 commit into from Nov 12, 2020

Conversation

erictapen
Copy link
Member

Motivation for this change
Things done

What is the backport policy on Wireguard?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen erictapen requested review from ivan and Ma27 and removed request for ivan November 12, 2020 12:11
@ofborg ofborg bot requested review from Mic92, globin, d-xo and elseym November 12, 2020 12:23
d-xo
d-xo approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@d-xo d-xo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • nixpkgs-review pr 103600 passes 🆗
  • nix build -f . pkgs.nixosTests.wiregard passes 🆗
  • confirmed I get a matching sha256 for src on my machine 🆗

lgtm ✨

@Ma27
Copy link
Member

Ma27 commented Nov 12, 2020

It contains a relevant fix for us and doesn't seem to have breaking changes. In the past, I backported those WireGuard releases.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 12, 2020
@Ma27 Ma27 merged commit e07fcb9 into NixOS:master Nov 12, 2020
@Ma27
Copy link
Member

Ma27 commented Nov 12, 2020

Ported to stable as 4289d0f.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@d-xo d-xo d-xo approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@globin globin Awaiting requested review from globin

@elseym elseym Awaiting requested review from elseym

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @Ma27 @d-xo