Fix default nix-path #4251
Merged
Fix default nix-path #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default nix-path values for nixpkgs and root channels were incorrect.
B4dM4n
added a commit
to B4dM4n/nix
that referenced
this pull request
Nov 23, 2020
Since c4c3c15 (NixOS#4251) building Nix for macOS with sandboxing fails: ``` getting status of /nix/var/nix/profiles/per-user/root/channels/nixpkgs: Operation not permitted ``` This happens, because `EvalSettings::getDefaultNixPath` tries to access paths outside the sandbox. Since the state-dir is not required for doc generation, it is set to the dummy folder. This needs to be done for all nix invocations during doc generation, as `EvalSettings::getDefaultNixPath` is called unconditionally.
B4dM4n
added a commit
to B4dM4n/nix
that referenced
this pull request
Nov 23, 2020
Since c4c3c15 (NixOS#4251) building Nix for macOS with sandboxing fails: ``` getting status of /nix/var/nix/profiles/per-user/root/channels/nixpkgs: Operation not permitted ``` This happens, because `EvalSettings::getDefaultNixPath` tries to access paths outside the sandbox. Since the state-dir is not required for doc generation, it is set to the dummy folder. This needs to be done for all nix invocations during doc generation, as `EvalSettings::getDefaultNixPath` is called unconditionally.
|
I think this has broken restricted evaluation (seen in a private hydra), where Hydra is looking for root's channels even though restricted evaluation is enabled. Maybe the default path should not be added while in restricted evaluation mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default nix-path values for nixpkgs and root channels were incorrect, and so were not actually being added to
NIX_PATHsince the erroneous paths don't exist.The test case is being able to import
<nixpkgs>without an explicitNIX_PATH:Is there anywhere I could plug in a test case for this?