Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.19.3 -> 1.19.4 #103621

Merged
merged 1 commit into from Nov 14, 2020
Merged

kubernetes: 1.19.3 -> 1.19.4 #103621

merged 1 commit into from Nov 14, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Nov 12, 2020 •
edited

(cherry picked from commit 39eadbb)
Backport of #103604

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
kubernetes: 1.19.3 -> 1.19.4
d531f06 
(cherry picked from commit 39eadbb)
Backport of NixOS#103604
JeffLabonte
JeffLabonte approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds and works here on NixOS

@srhb srhb merged commit 29e9c10 into NixOS:release-20.09 Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@JeffLabonte JeffLabonte JeffLabonte approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@johanot johanot Awaiting requested review from johanot

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @saschagrunert @JeffLabonte