Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.19.3 -> 1.19.4 #103604

Merged
merged 1 commit into from Nov 12, 2020
Merged

kubernetes: 1.19.3 -> 1.19.4 #103604

merged 1 commit into from Nov 12, 2020

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Nov 12, 2020

Motivation for this change

Kubernetes 1.19 bugfix release.
Changelog: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#changelog-since-v1193

One fix we've been waiting for in particular is: kubernetes/kubernetes#95260 (high cpu usage for kubectl drain).

RBAC and DNS tests run without errors locally.

cc @saschagrunert @srhb @adamtulinius

Please backport to 20.09. :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker November 12, 2020 12:39
@srhb srhb added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 12, 2020
saschagrunert
saschagrunert approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srhb srhb self-assigned this Nov 12, 2020
@srhb srhb merged commit 96ba24c into NixOS:master Nov 12, 2020
srhb pushed a commit to srhb/nixpkgs that referenced this pull request Nov 12, 2020
@srhb
kubernetes: 1.19.3 -> 1.19.4
d531f06 
(cherry picked from commit 39eadbb)
Backport of NixOS#103604
@srhb srhb mentioned this pull request Nov 12, 2020
Merged
10 tasks
@johanot johanot deleted the kubernetes-1.19.4 branch November 12, 2020 18:43
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees

@srhb srhb

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johanot @srhb @saschagrunert @erictapen