Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.reedsolo: init at 1.5.4 #103615

Merged
merged 1 commit into from Nov 18, 2020
Merged

python3Packages.reedsolo: init at 1.5.4 #103615

merged 1 commit into from Nov 18, 2020

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

Required for esptool update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP
Copy link
Contributor Author

Done

jonringer
jonringer reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done without git rebase -i by doing:

git reset HEAD~2                    # move fix-up commits into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

However, git rebase -i is a more powerful alternative, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

@yorickvP @jonringer
python3Packages.reedsolo: init at 1.5.4
b1dc63d 
reedsolo: maintain, add tests, fix cython

reedsolo: Apply suggestions from code review

Co-authored-by: Jonathan Ringer <jonringer@users.noreply.github.com>
@yorickvP
Copy link
Contributor Author

Okay, rebased. Please update your example to --force-with-lease ;)

@jonringer
Copy link
Contributor

i actually revised it by only mentioning git rebase

jonringer
jonringer approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103615 1

3 packages built:
  • python27Packages.reedsolo
  • python37Packages.reedsolo
  • python38Packages.reedsolo

@jonringer jonringer merged commit 9ca12dc into NixOS:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yorickvP @jonringer