Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sound_effect property doesn't seem to work with helicopters #8348

Closed
javelinnl opened this issue Nov 29, 2020 · 5 comments · Fixed by #8347
Closed

sound_effect property doesn't seem to work with helicopters #8348

javelinnl opened this issue Nov 29, 2020 · 5 comments · Fixed by #8347

Comments

@javelinnl
Copy link

Changing the takeoff sound for helicopters using the sound_effect property doesn't seem to work. I've tried the same code with other vehicles including regular aircraft and it only fails when setting the aircraft to helicopter. Using a callback as a workaround works fine though.
@glx22
Copy link
Contributor

glx22 commented Nov 29, 2020

It's not a NML limitation (see GRF specs)

@frosch123
Copy link
Member

Apparently "sound_effect" is intentionally ignored for helicopters: https://newgrf-specs.tt-wiki.net/wiki/Action0/Vehicles/Planes#Sound_effect_.2812.29

You can use the sound_effect callback though:
https://newgrf-specs.tt-wiki.net/wiki/NML:Vehicles#Vehicle_callbacks

@TrueBrain
Copy link
Member

TrueBrain commented Nov 29, 2020 •
edited

So if I edit the wiki to remove that part, does that magically fix anything? :)

@frosch123
Copy link
Member

The default value of the property is the aircraft sounds. So if you remove the "helicopter" condition, most NewGRF helicopters will play the aircraft take-off sound.

@frosch123 frosch123 transferred this issue from OpenTTD/nml Nov 29, 2020
@frosch123 frosch123 mentioned this issue Nov 29, 2020
Merged
@frosch123
Copy link
Member

Possible solution in #8347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change: [NewGRF] Use aircraft property 12 also for helicopters. frosch123/OpenTTD
4 participants
@TrueBrain @glx22 @frosch123 @javelinnl