Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_11: 11.0.0 -> 11.0.1 #105394

Merged
merged 1 commit into from Jan 9, 2021
Merged

llvmPackages_11: 11.0.0 -> 11.0.1 #105394

merged 1 commit into from Jan 9, 2021

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Nov 29, 2020 •
edited

Motivation for this change

https://lists.llvm.org/pipermail/release-testers/2021-January/001436.html
http://lists.llvm.org/pipermail/release-testers/2020-December/001422.html
http://lists.llvm.org/pipermail/llvm-dev/2020-November/146911.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif
Copy link
Contributor Author

ggreif commented Nov 29, 2020 •
edited

@GrahamcOfBorg build llvmPackages_11

@ggreif ggreif changed the title llvmPackages_11: 11.0.0 -> 11.0.1rc1 llvmPackages_11: 11.0.0 -> 11.0.1rc2 Dec 20, 2020
@ggreif ggreif force-pushed the master branch 2 times, most recently from 7d75a09 to 6967512 Compare December 23, 2020 13:42
@ggreif ggreif marked this pull request as ready for review December 23, 2020 13:53
@ofborg ofborg bot requested a review from lovek323 January 8, 2021 21:54
@ggreif ggreif changed the title llvmPackages_11: 11.0.0 -> 11.0.1rc2 llvmPackages_11: 11.0.0 -> 11.0.1 Jan 8, 2021
@ggreif
Copy link
Contributor Author

ggreif commented Jan 8, 2021

@lovek323 @7c6f434c @primeos I think this is good to go now.

primeos
primeos reviewed Jan 9, 2021
View reviewed changes
Copy link
Member

@primeos primeos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try to build Chromium Mesa and merge if it works.
(Edit: For some reasons I had to commit both suggestions separately but I'll squash and merge anyway.)

pkgs/development/compilers/llvm/11/clang/default.nix Show resolved Hide resolved
pkgs/development/compilers/llvm/11/default.nix Outdated Show resolved Hide resolved
@primeos primeos changed the base branch from master to staging January 9, 2021 20:28
@primeos
Copy link
Member

primeos commented Jan 9, 2021

@GrahamcOfBorg build mesa

primeos
primeos approved these changes Jan 9, 2021
View reviewed changes
Copy link
Member

@primeos primeos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(And sorry about the minor mess I've produced earlier, I was a bit tired...)

@primeos primeos merged commit 220bcfc into NixOS:staging Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggreif @primeos