New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: Improve musl support #105383
rustc: Improve musl support #105383
Conversation
I'd like to understand this better; could you explain what the relevant difference is here? Also, you can remove the |
When you compile stuff than any or all of the following platforms can be musl: build (the platform the build is running on), host (the platform the binary is built for) or target (the platform the compiler can compile code for). This is now correctly set by the expression. |
I meant the difference between |
I tried building
|
There was a slight error in the target logic I didn't notice before, and also should do the same thing for the other platforms.
f5f0381
to
47b9976
Compare
Putting it altogether:
|
To be clear (not trying to imply you disagree) I still like doing these fixes even if they are of no practical benefit because:
|
Motivation for this change
There was a slight error in the target logic I didn't notice before, and
also should do the same thing for the other platforms.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)