Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ion: fix build on darwin #105395

Merged
merged 1 commit into from Dec 28, 2020
Merged

ion: fix build on darwin #105395

merged 1 commit into from Dec 28, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 29, 2020

Motivation for this change

Can be backported to 20.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 29, 2020
@ofborg ofborg bot requested a review from dywedir November 29, 2020 20:54
@SuperSandro2000
Copy link
Member

Fails with:

test result: ok. 202 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/x86_64-apple-darwin/release/deps/ion-dded52572a699b0b

running 1 test
test binary::completer::tests::filename_completion ... FAILED

failures:

---- binary::completer::tests::filename_completion stdout ----
thread 'binary::completer::tests::filename_completion' panicked at 'assertion failed: `(left == right)`
  left: `[]`,
 right: `["~/"]`', src/binary/completer.rs:345:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    binary::completer::tests::filename_completion

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--bin ion'

@Mic92
Copy link
Member

Mic92 commented Nov 30, 2020

Wild guess: Maybe it wants a valid $HOME? Try export HOME=$TMPDIR before running the test.

@r-burns
Copy link
Contributor Author

r-burns commented Nov 30, 2020

Hmm, you're right, but this doesn't show up in nix-build, only nixpkgs-review. Is the latter doing some extra sandboxing or something?

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2020

Hmm, you're right, but this doesn't show up in nix-build, only nixpkgs-review. Is the latter doing some extra sandboxing or something?

Yes. it enables sandboxing also on macOS.

@SuperSandro2000
Copy link
Member

@r-burns friendly reminder

@r-burns
Copy link
Contributor Author

r-burns commented Dec 27, 2020

I don't know how to fix the sandboxing issue, guess I'll close this

@r-burns r-burns closed this Dec 27, 2020
@Mic92 Mic92 reopened this Dec 28, 2020
@Mic92
Copy link
Member

Mic92 commented Dec 28, 2020

I think it still provides some value even if it does not build with sandbox.

@Mic92 Mic92 merged commit db103e0 into NixOS:master Dec 28, 2020
@r-burns r-burns deleted the ion branch December 28, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-burns @SuperSandro2000 @Mic92