Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qjackctl: add jackSession option #105382

Merged
merged 1 commit into from Dec 24, 2020
Merged

qjackctl: add jackSession option #105382

merged 1 commit into from Dec 24, 2020

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Nov 29, 2020

Motivation for this change

This adds jackSession option, which allows to enable or disable jack session support.

The option is disabled by default for the following reasons:

  1. The JACK-Session API is deprecated: https://jackaudio.org/api/group__JackSessionManagerAPI.html
  2. Disabling this feature allows to use qjackctl with PipeWire

See also: #102547

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cillianderoiste

@ashkitten
Copy link
Contributor

works for me with pipewire

@collares
Copy link
Member

I hit this problem today.Thanks for the patch! Would be great to get this merged :)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/303

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105382 run on x86_64-linux 1

1 package built:
  • qjackctl

SuperSandro2000
SuperSandro2000 reviewed Dec 23, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the review commit.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105382 run on x86_64-linux 1

1 package built:
  • qjackctl

@gebner gebner merged commit e3b15e2 into NixOS:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@archseer archseer archseer approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@suhr @ashkitten @collares @nixos-discourse @SuperSandro2000 @archseer @gebner