Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codimd: 1.6.0 -> 1.7.0, rename to hedgedoc #105385

Merged
merged 3 commits into from Dec 22, 2020
Merged

codimd: 1.6.0 -> 1.7.0, rename to hedgedoc #105385

merged 3 commits into from Dec 22, 2020

Conversation

WilliButz
Copy link
Member

@WilliButz WilliButz commented Nov 29, 2020 •
edited

This PR is pending on the actual release of 1.7.0. For early reviews/suggestions the first release candidate is currently used.
1.7.0 was release about two hours ago.

Motivation for this change

CodiMD is now called HedgeDoc.
https://github.com/hedgedoc/hedgedoc/releases/tag/1.7.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and Ma27 November 29, 2020 18:20
@Ma27 Ma27 mentioned this pull request Dec 3, 2020
Closed
10 tasks
@WilliButz WilliButz changed the title codimd: 1.6.0 -> 1.7.0-rc1, rename to hedgedoc codimd: 1.6.0 -> 1.7.0, rename to hedgedoc Dec 21, 2020
@WilliButz WilliButz marked this pull request as ready for review December 22, 2020 00:14
@WilliButz
Copy link
Member Author

WilliButz commented Dec 22, 2020 •
edited

I successfully deployed this to an existing installation and could not find any issues.

@WilliButz
codimd: 1.6.0 -> 1.7.0, rename to hedgedoc
e19995e 
CodiMD was renamed to HedgeDoc and is now built with nodejs-14_x.

https://github.com/hedgedoc/hedgedoc/releases/tag/1.7.0
@WilliButz
nixos/codimd: rename to hedgedoc
1c55621 
CodiMD was renamed to HedgeDoc. The user, group and state directory,
will be named hedgedoc instead of codimd, starting with stateVersion
"21.03".
@WilliButz
nixos/doc: add note about codimd -> hedgedoc to release notes
97e863a
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test hedgedoc

@Ma27 Ma27 merged commit 45e371e into NixOS:master Dec 22, 2020
@WilliButz WilliButz mentioned this pull request Dec 27, 2020
Merged
11 tasks
@Ma27 Ma27 mentioned this pull request Dec 28, 2020
Merged
10 tasks
@WilliButz WilliButz deleted the update/codimd/1.7.0 branch May 14, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@Ma27 Ma27 Ma27 approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @Ma27 @SuperSandro2000