Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wafHook: use python3 #105406

Closed
wants to merge 1 commit into from
Closed

wafHook: use python3 #105406

wants to merge 1 commit into from

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 29, 2020

Motivation for this change

Trying to remove things from the minimal ISO that still rely on Python 2. #105392

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor Author

lukegb commented Nov 30, 2020

This definitely breaks some things, but on the whole things are happier than I'd expect. Waiting for my build to complete to estimate the damage.

@ajs124
Copy link
Member

ajs124 commented Nov 30, 2020

We already have 2-3 versions of this PR and there are a bunch of reasons why we might not want to do this like you're doing it here.

See #69310 and #104701.

@lukegb lukegb closed this Nov 30, 2020
@lukegb lukegb deleted the r13y-yaks-wafhook branch November 30, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @ajs124