Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parted: switch to python3 #105407

Closed
wants to merge 2 commits into from
Closed

parted: switch to python3 #105407

wants to merge 2 commits into from

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 29, 2020 •
edited

Motivation for this change

Trying to remove things from the minimal ISO that still rely on Python 2. #105392

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor Author

lukegb commented Nov 30, 2020

Result of nixpkgs-review pr 105407 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • libsForQt512.kpmcore
  • nixops
  • nixopsUnstable
  • nixops_1_6_1
  • rabbitvcs
  • xmonad_log_applet
2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
135 packages built:
  • adapta-gtk-theme
  • almanah
  • atom
  • atom-beta
  • bubblemail
  • calamares
  • calls
  • cantata
  • chrome-gnome-shell
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-control-center
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • clementine
  • clementineUnfree
  • collectd
  • collectd-data
  • docker-machine-kvm
  • docker-machine-kvm2
  • dropbox-cli
  • elementary-planner
  • empathy (gnome3.empathy)
  • enlightenment.enlightenment
  • evolution-data-server (gnome3.evolution-data-server ,gnome3.evolution_data_server)
  • evolution-ews
  • f3
  • far2l
  • fatresize
  • feedreader
  • folks (gnome3.folks)
  • gfbgraph (gnome3.gfbgraph)
  • gnome-multi-writer
  • gnome-online-accounts (gnome3.gnome-online-accounts ,gnome3.gnome_online_accounts)
  • gnome-photos (gnome3.gnome-photos)
  • gnome-recipes
  • gvfs (gnome2.gvfs)
  • gnome3.bijiben (gnome3.gnome-notes)
  • gnome3.cheese
  • gnome3.evolution
  • gnome3.file-roller
  • gnome3.geary
  • gnome3.gnome-applets
  • gnome3.gnome-boxes
  • gnome3.gnome-calendar
  • gnome3.gnome-contacts
  • gnome3.gnome-control-center (gnome3.gnome_control_center)
  • gnome3.gnome-disk-utility
  • gnome3.gnome-flashback
  • gnome3.gnome-initial-setup
  • gnome3.gnome-maps
  • gnome3.gnome-music
  • gnome3.gnome-online-miners
  • gnome3.gnome-panel
  • gnome3.gnome-session (gnome3.gnome_session)
  • gnome3.gnome-shell (gnome3.gnome_shell)
  • gnome3.gnome-software
  • gnome3.gnome-terminal (gnome3.gnome_terminal)
  • gnome3.gnome-todo
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
  • gnome3.gnome-user-share
  • grilo-plugins (gnome3.grilo-plugins)
  • gnome3.gvfs
  • libgdata (gnome3.libgdata)
  • libzapojit (gnome3.libzapojit)
  • gnome3.nautilus
  • gnome3.nautilus-python
  • gnome3.pomodoro
  • shotwell (gnome3.shotwell)
  • gnome3.totem
  • tracker-miners (gnome3.tracker-miners)
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • gnufdisk
  • gparted
  • hal-flash
  • haskellPackages.libvirt-hs
  • libblockdev
  • libguestfs
  • libsForQt5.kpmcore (libsForQt515.kpmcore)
  • libsForQt514.kpmcore
  • libvirt
  • libvirt-glib
  • libvirt_5_9_0
  • libvmi
  • mailnagWithPlugins
  • mate.mate-utils
  • minikube
  • minishift
  • multibootusb
  • nwipe
  • pantheon.elementary-calendar
  • pantheon.elementary-greeter
  • pantheon.elementary-session-settings
  • pantheon.extra-elementary-contracts
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-with-indicators
  • parted
  • partition-manager
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • psensor
  • python27Packages.guestfs
  • python27Packages.libvirt
  • python27Packages.pyparted
  • python37Packages.guestfs
  • python37Packages.libvirt
  • python37Packages.pyparted
  • python38Packages.guestfs
  • python38Packages.libvirt
  • python38Packages.pyparted
  • rapid-photo-downloader
  • rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
  • rubyPackages_2_5.ruby-libvirt
  • rubyPackages_2_7.ruby-libvirt
  • spaceFM
  • terraform-full
  • terraform-providers.libvirt
  • terraform_0_11-full
  • udiskie
  • udisks (udisks2)
  • usermount
  • vagrant
  • vifm-full
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst
  • woeusb
  • xfce.gigolo
  • xfce.gvfs
  • xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
  • xfce.thunar-archive-plugin
  • xfce.thunar-dropbox-plugin
  • xfce.xfdesktop

@lukegb lukegb changed the base branch from master to staging November 30, 2020 00:09
@lukegb lukegb marked this pull request as ready for review November 30, 2020 00:09
@lukegb
Copy link
Contributor Author

lukegb commented Nov 30, 2020

@raboof

@lukegb
Copy link
Contributor Author

lukegb commented Nov 30, 2020

@ajs124 I'm assuming there's probably a PR for this too. I probably should've checked first, heh

@lukegb lukegb closed this Nov 30, 2020
@lukegb lukegb deleted the r13y-yaks-parted branch November 30, 2020 00:40
@raboof
Copy link
Member

raboof commented Nov 30, 2020

I see you found my PR at #104703 - you could still add yourself as maintainer though :)

@zimbatm zimbatm added this to In progress in R13y via automation Dec 1, 2020
@Artturin Artturin removed this from In progress in R13y Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @raboof