Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunar: fix wrapper build #104627

Merged
merged 1 commit into from Dec 3, 2020
Merged

thunar: fix wrapper build #104627

merged 1 commit into from Dec 3, 2020

Conversation

andresilva
Copy link
Member

Motivation for this change

Fix #101647.

The issue was that we were trying to remove the target thunar.service file rather than the symlinked directory pointing to it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

cc @jtojnar

@andresilva
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 3, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@vikanezrimaya
Copy link
Member

LGTM. /status needs_merger

By the way, #104619 is a duplicate of this.

@marvin-mk2 marvin-mk2 bot requested a review from timokau December 3, 2020 17:40
@andresilva
Copy link
Member Author

Oh, I had not noticed there was another PR for this. Funny that I created the issue for this more than a month ago and we both managed to submit PRs on the same day.

timokau
timokau approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@timokau timokau merged commit d652ba3 into NixOS:master Dec 3, 2020
@timokau timokau mentioned this pull request Dec 3, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@vikanezrimaya vikanezrimaya Awaiting requested review from vikanezrimaya

Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 0 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thunar with plugins fails to install
4 participants
@andresilva @jonringer @vikanezrimaya @timokau