Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.class-registry: Add typing as propagatedBuildInput when python2 #104630

Merged
merged 1 commit into from Dec 4, 2020
Merged

pythonPackages.class-registry: Add typing as propagatedBuildInput when python2 #104630

merged 1 commit into from Dec 4, 2020

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Nov 22, 2020 •
edited

Motivation for this change

When using python2 the package class-registry expects the dependency typing. This PR addresses this fact.

Reference: https://github.com/lenddoefl/class-registry/blob/master/setup.py#L32

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seppeljordan
Copy link
Contributor Author

Result of nixpkgs-review pr 104630 1

1 package built:
  • python27Packages.class-registry

@ofborg ofborg bot requested a review from kevincox November 22, 2020 20:49
@seppeljordan
Copy link
Contributor Author

Result of nixpkgs-review pr 104630 1

1 package built:
  • python27Packages.class-registry

@seppeljordan
Copy link
Contributor Author

@FRidh @jonringer Hi, can I do anything from my side to help with this PR?

@FRidh FRidh merged commit 263ddd7 into NixOS:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seppeljordan @SuperSandro2000 @FRidh