Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunar: fix build error #104619

Closed
wants to merge 1 commit into from

Conversation

mgmillani
Copy link

$out/lib/systemd/user is a symlink to ${thunar}/lib/systemd/user.
To change the file $out/lib/systemd/user/thunar.service, we need to turn
that link into a folder.

Motivation for this change

Closes #101647

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$out/lib/systemd/user is a symlink to ${thunar}/lib/systemd/user.
To change the file $out/lib/systemd/user/thunar.service, we need to turn
that link into a folder.
@timokau
Copy link
Member

timokau commented Dec 3, 2020

Resolved by #104627. Still, thanks for contributing!

@timokau timokau closed this Dec 3, 2020
@timokau
Copy link
Member

timokau commented Dec 3, 2020

(I merged the other PR because I saw it first. The additional documentation is nice too. Nothing wrong with your version though :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thunar with plugins fails to install
3 participants