stage-1: Acknowledge recovery boot mode #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
added
3. topic: stage-1
samueldr
force-pushed
the
feature/stage-1-recovery-acknowledge
branch
3 times, most recently
from
3c3075c
to
4c46806
Compare
To be shown, the publisher has to publish the `recovery` value.
Otherwise we might miss the last message, which may include things to present to the user, e.g. the label "Continuing to ..."
samueldr
force-pushed
the
feature/stage-1-recovery-acknowledge
branch
from
4c46806
to
fd0a985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more intended to show that the device will go into recovery once the boot is done... booting...
Though the boot is going so fast that the "Continuing" message, at least in QEMU, appears at the same time.
This will be more useful with less shallow systems, and real systems that are slower.