[CSS] Serialize flex property into longhands #26607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 22, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2550331
branch
from
8e1b22d
to
1b79738
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2550331
branch
2 times, most recently
from
fedffc9
to
666c43f
Compare
Currently, flex with CSS-wide keyword is serialized by shorthands. We should serialize into longhands per spec. So that it should include flex-basis, flex-grow, and flex-shrink properties. Bug: 1149779 Change-Id: I2431f89ac878d6d50686ce9faa75f9f4dd13f6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550331 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#834240}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2550331
branch
from
666c43f
to
ef3fa9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, flex with CSS-wide keyword is serialized by shorthands. We
should serialize into longhands per spec. So that it should include
flex-basis, flex-grow, and flex-shrink properties.
Bug: 1149779
Change-Id: I2431f89ac878d6d50686ce9faa75f9f4dd13f6f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550331
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Emilio Cobos Álvarez <emilio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834240}