delft/eris: include Prometheus port in nginx proxy_pass directive #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukegb
changed the title
In NixOS 20.09, the listenAddress directive was changed to be purely for the address and not for the address:port combination as previously. This results in nginx now talking to *itself* using plaintext HTTP on 0.0.0.0. With forceSSL, this means nginx issues a redirect for the hostname -> the client gets a redirect to https://0.0.0.0/prometheus/.... Fixes NixOS#133
lukegb
force-pushed
the
lukegb/fix-133
branch
from
c62b127
to
8e4bfa5
Compare
lukegb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NixOS 20.09, the listenAddress directive was changed to be purely
for the address and not for the address:port combination as previously.
This results in nginx now talking to itself using plaintext HTTP on
0.0.0.0. With forceSSL, this means nginx issues a redirect for the
hostname -> the client gets a redirect to
https://0.0.0.0/prometheus/....
Fixes #133