Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for USB3 flashing issue #244

Merged
merged 1 commit into from Nov 23, 2020
Merged

Solution for USB3 flashing issue #244

merged 1 commit into from Nov 23, 2020

Conversation

leenaars
Copy link
Contributor

In some cases, you cannot flash a new firmware when using a USB3 cable.

@samueldr
Copy link
Member

Hi! 👋

Thanks for the contribution.

First, if you were wondering about the failing checks, a recent GitHub-side deprecation broke the checks, which was fixed today.

Now, about the contribution proper.

The documentation (including device-specific notes) are written in AsciiDoc, using Asciidoctor for rendering. The syntax quick reference can help when searching for the usual patterns.

Though, as the text seems appropriate, I'll translate from Markdown to Asciidoc :).

Only thing of note is that I'll add a title to the item, and re-order this. I like sections to go from general to specific, where it makes sense.

I have refreshed the commands to (1) remove the needless sudo su; the xargs command uses sudo already and (2) use nix-shell as lspci is not part of the default packages installed on NixOS.

I may have rephrase some bits to flow better when read.

This was pushed on top of your contribution; if you see anything wrong in my edits tell me. Otherwise it will be merged with the changes (in a day or more).

@leenaars
Copy link
Contributor Author

I completely agree with the improvements, and of course converting to Asciidoc makes perfect sense. Thanks!

@samueldr samueldr merged commit 4a64556 into NixOS:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants