Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pypandoc: fix tests for pandoc >= 2.11.2 #104625

Merged
merged 1 commit into from Nov 26, 2020
Merged

pythonPackages.pypandoc: fix tests for pandoc >= 2.11.2 #104625

merged 1 commit into from Nov 26, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

A change in the Markdown output of pandoc breaks the unicode input test
of pypandoc.

See also JessicaTegner/pypandoc#204.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
pythonPackages.pypandoc: fix tests for pandoc >= 2.11.2
96a9788 
A change in the Markdown output of pandoc breaks the unicode input test
of pypandoc.

See also JessicaTegner/pypandoc#204
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build python3Packages.pypandoc

@ofborg ofborg bot requested a review from bennofs November 22, 2020 18:28
@siraben siraben mentioned this pull request Nov 26, 2020
Merged
10 tasks
@siraben
Copy link
Member

siraben commented Nov 26, 2020

Result of nixpkgs-review pr 104625 1

3 packages built:
  • python27Packages.pypandoc
  • python37Packages.pypandoc
  • python38Packages.pypandoc

jonringer
jonringer approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/104625
4 packages built:
apostrophe python27Packages.pypandoc python37Packages.pypandoc python38Packages.pypandoc

@jonringer jonringer merged commit c0fa30b into NixOS:master Nov 26, 2020
@sternenseemann sternenseemann deleted the pypandoc-headings branch February 13, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @siraben @jonringer