Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: 4.10.3 -> 4.11.1 #103954

Merged
merged 1 commit into from Nov 16, 2020
Merged

slack: 4.10.3 -> 4.11.1 #103954

merged 1 commit into from Nov 16, 2020

Conversation

JesusMtnez
Copy link
Contributor

Motivation for this change

Bump to latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from mmahut November 16, 2020 06:43
nh2
nh2 requested changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails to launch for me on NixOS, error:

[nix-shell:~/.cache/nixpkgs-review/pr-103954]$ slack 
/nix/store/4b85bq6m3qavcz5cvk6gmnnlgcghqqsc-slack-4.11.1/lib/slack/slack: error while loading shared libraries: libxkbcommon.so.0: cannot open shared object file: No such file or directory

Doesn't happen with 4.10.3.

nh2
nh2 approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails to launch for me on NixOS, error:

I've force-pushed a fix to add libxkbcommon to rpath, now it's good to go.

@nh2 nh2 merged commit 14f2dc1 into NixOS:master Nov 16, 2020
@JesusMtnez JesusMtnez deleted the slack branch November 17, 2020 05:17
@stigtsp stigtsp mentioned this pull request Nov 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JesusMtnez @nh2