Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcio: split outputs to remove build protobuf from closure #103945

Merged
merged 2 commits into from Nov 19, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

The Python protobuf library has C++ protobuf in propagatedNativeBuildInputs. When cross-compiling this causes a build arch package to end up in grpcio's runtime closure, which can be be prevented by splitting outputs.

cc @marsam @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

protobuf propagates build-arch protobuf, and this commit prevents it from
ending up in grpcio's runtime closure.
protobuf propagates build-arch protobuf, and this prevents it from ending up in
the runtime closure.
@lopsided98
Copy link
Contributor Author

@ofborg build python3Packages.grpcio python3Packages.grpcio-tools pkgsCross.aarch64-multiplatform.python3Packages.grpcio pkgsCross.aarch64-multiplatform.python3Packages.grpcio-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants