Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c++latest everywhere with MSVC #2786

Merged
merged 6 commits into from
Nov 16, 2020
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Nov 16, 2020

No description provided.

#define PRINCIPIA_MAX(l, r) std::max((l), (r))
#define PRINCIPIA_MAX3(x1, x2, x3) std::max({(x1), (x2), (x3)})
#define PRINCIPIA_MAX4(x1, x2, x3) std::max({(x1), (x2), (x3), (x4)})
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to macros.hpp, drop the undefs.

@eggrobin eggrobin added the LGTM label Nov 16, 2020
@eggrobin eggrobin merged commit cbc3f20 into mockingbirdnest:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants