Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-beta-bin: 81.0b4 -> 84.0b4, firefox-devedition-bin: 80.0b8 -> 84.0b4 #103951

Merged
merged 2 commits into from Nov 25, 2020
Merged

firefox-beta-bin: 81.0b4 -> 84.0b4, firefox-devedition-bin: 80.0b8 -> 84.0b4 #103951

merged 2 commits into from Nov 25, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 16, 2020 •
edited

Motivation for this change

https://www.mozilla.org/en-US/firefox/84.0beta/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review 1

4 packages built:
  • firefox-beta-bin
  • firefox-beta-bin-unwrapped
  • firefox-devedition-bin
  • firefox-devedition-bin-unwrapped

@stigtsp stigtsp requested review from andir and taku0 November 16, 2020 04:51
@stigtsp stigtsp force-pushed the package/firefox-beta-bin-83.0b10 branch from 62e18a5 to 973d527 Compare November 19, 2020 04:54
@stigtsp stigtsp changed the title firefox-beta-bin: 81.0b4 -> 83.0b10, firefox-devedition-bin: 80.0b8 -> 83.0b10 firefox-beta-bin: 81.0b4 -> 84.0b2, firefox-devedition-bin: 80.0b8 -> 84.0b2 Nov 19, 2020
@stigtsp
Copy link
Member Author

stigtsp commented Nov 19, 2020

Updated PR to 84.0b2 for both firefox-beta-bin and firefox-devedition-bin

@stigtsp
Copy link
Member Author

stigtsp commented Nov 19, 2020

Both tested OK on linux x64

Result of nixpkgs-review pr 103951 1

4 packages built:
  • firefox-beta-bin
  • firefox-beta-bin-unwrapped
  • firefox-devedition-bin
  • firefox-devedition-bin-unwrapped

@stigtsp stigtsp force-pushed the package/firefox-beta-bin-83.0b10 branch from 973d527 to 41c91ed Compare November 25, 2020 12:24
@stigtsp stigtsp changed the title firefox-beta-bin: 81.0b4 -> 84.0b2, firefox-devedition-bin: 80.0b8 -> 84.0b2 firefox-beta-bin: 81.0b4 -> 84.0b4, firefox-devedition-bin: 80.0b8 -> 84.0b4 Nov 25, 2020
@stigtsp
Copy link
Member Author

stigtsp commented Nov 25, 2020

Updated PR to 84.0b4 for both firefox-beta-bin and firefox-devedition-bin

Tested both OK

Result of nixpkgs-review pr 103951 1

4 packages built:
  • firefox-beta-bin
  • firefox-beta-bin-unwrapped
  • firefox-devedition-bin
  • firefox-devedition-bin-unwrapped

lukegb
lukegb approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andir andir merged commit 25d7bcc into NixOS:master Nov 25, 2020
@stigtsp stigtsp mentioned this pull request Nov 25, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@andir andir Awaiting requested review from andir

@taku0 taku0 Awaiting requested review from taku0

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @lukegb @andir