Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convos: 4.40 -> 5.00 #103950

Merged
merged 1 commit into from Nov 19, 2020
Merged

convos: 4.40 -> 5.00 #103950

merged 1 commit into from Nov 19, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 16, 2020

Motivation for this change

https://github.com/Nordaaker/convos/blob/5.00/Changes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp changed the title convos: 4.40 -> 4.42 convos: 4.40 -> 5.00 Nov 19, 2020
@stigtsp
Copy link
Member Author

stigtsp commented Nov 19, 2020

Tested OK on linux x64

Result of nixpkgs-review pr 103950 1

1 package built:
  • convos

@stigtsp
Copy link
Member Author

stigtsp commented Nov 19, 2020

@GrahamcOfBorg build convos.tests

@stigtsp stigtsp merged commit e0feea2 into NixOS:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant