sshd: disable trigger limit for systemd socket #103946
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
lopsided98
force-pushed
the
sshd-trigger-limit
branch
from
85337f5 to
9b0a4d0
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
rycee
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
I think this is worth merging. I actually believe I've encountered this in April:
…
Apr 13 00:50:39 natto systemd[1]: sshd.socket: Too many incoming connections (64), dropping connection.
Apr 13 00:50:39 natto systemd[1]: sshd.socket: Too many incoming connections (64), dropping connection.
Apr 13 00:50:39 natto systemd[1]: sshd.socket: Too many incoming connections (64), dropping connection.
Apr 13 00:50:40 natto systemd[1]: sshd.socket: Trigger limit hit, refusing further activation.
Apr 13 00:50:40 natto systemd[1]: sshd.socket: Failed with result 'trigger-limit-hit'.
Apr 13 00:50:40 natto systemd[1]: sshd.socket: Consumed 1min 3.131s CPU time, received 209.8G IP traffic, sent 9.8G IP traffic.
Apr 20 18:54:51 natto systemd[1]: Listening on SSH Socket.
I had physical access to the host on the 20th and could restart sshd.
stale
bot
removed
the
2.status: stale
|
@ofborg eval |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
I still use this patch and would like it to be merged. |
stale
bot
removed
the
2.status: stale
|
@ofborg eval |
|
@lopsided98 can you rebase on master to fix the github actions? |
When startWhenNeeded is enabled, a brute force attack on sshd will cause systemd to shut down the socket, locking out all SSH access to the machine. Setting TriggerLimitIntervalSec to 0 disables this behavior.
lopsided98
force-pushed
the
sshd-trigger-limit
branch
from
9b0a4d0 to
f5e0f29
Compare
ofborg
bot
added
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
|
@ofborg test openssh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When
startWhenNeededis enabled, a brute force attack on sshd will cause systemd to shut down the socket, locking out all SSH access to the machine. SettingTriggerLimitIntervalSecto 0 disables this behavior.This has been observed on other distros as well, for example: https://bugs.archlinux.org/task/62248
cc @edolstra @infinisil @FRidh
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)