New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vulkan-tools-lunarg: init at 1.2.141.0 #103957
Conversation
oh, @Ralith please feel free to add yourself to the maintainers list if you'd like :D |
These are dependencies of other layers such as the layers in LunarG Vulkan Tools
ef9e3cb
to
0eb2647
Compare
For the license field, it's mainly asl20, but some more permissively licensed things: https://github.com/LunarG/VulkanTools/blob/master/LICENSE.txt#L1-L3 |
0eb2647
to
8d7f877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
# The version must match that in vulkan-headers | ||
inherit version; | ||
|
||
src = fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src = fetchFromGitHub { | |
src = (assert versoin == vulkan-headers.version; fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Kinda confusing naming, but I guess that's upstream's fault. I wouldn't mind having a description field that disambiguates them with a little more detail.
@Ralith, Would it be possible for you to write a comment explaining the |
Use the github repo here as the homepage as lunarg.com has heaps of stuff besides these tools.
8d7f877
to
b2fae2d
Compare
I've made some changes to the metadata of both packages and it should be a little clearer, although given the similarity of both project and their similar naming there's only so much that can be done... |
Thanks!
…On Tue, Nov 17, 2020, 4:44 PM Doron Behar ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#103957 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXBRNKUSTGKZKF7AV2LSQIZPXANCNFSM4TW3VI6Q>
.
|
Hello, I added the library path because vulkaninfo opens libvulkan(found in vulkan-loader) using dlopen. It is documented just above |
Requires some small changes to vulkan-validation-layers on which it
depends.
I chose the name vulkan-tools-lunarg to keep it alphabetically near its
sister packages, and to distinguish it from the other vulkan-tools.
Things done
I've tested that the binaries don't crash on start
The setup hook exposes the layers correctly to the vulkan loader and I've tested a couple of the layers with a vulkan program.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)