Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "python3Packages.pytest-testmon: 1.0.2 -> 1.0.3" #103958

Merged
merged 1 commit into from Nov 22, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 16, 2020

This reverts commit 0fc5e60.

For some reason the v1.0.3 PyPI tarball ships with tests that expect pytest-testmon master instead of the v1.0.3 code (tarpas/pytest-testmon#158), causing these tests to fail against 1.0.3 itself.

Alternative to #103786

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This reverts commit 0fc5e60.

For some reason the v1.0.3 PyPI tarball ships with tests that expect pytest-testmon master instead of the v1.0.3 code (tarpas/pytest-testmon#158), causing these tests to fail against 1.0.3 itself.
Copy link
Contributor

@dmvianna dmvianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good.

@raboof
Copy link
Member Author

raboof commented Nov 16, 2020

/cc @jonringer since it looks like you did the same before in 9f1bd6f

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build tested on Python3.7 and 3.8. LGTM.

@mweinelt mweinelt merged commit a62e673 into NixOS:staging Nov 22, 2020
@unode
Copy link
Member

unode commented Nov 22, 2020

This is failing on master and is causing mnemosyne to fail as consequence. Reported as a dependency failure in #104441
Can we get this merged to master as well?

Also, is the title of this issue incorrect? The code change reads as a downgrade but the title reads an upgrade. please ignore, missed the "revert"

@mweinelt
Copy link
Member

This is on its way into master, but was targeted for staging first. The title states this is a revert of the upgrade from 1.0.2 to 1.0.3.

@raboof
Copy link
Member Author

raboof commented Nov 23, 2020

This is failing on master and is causing mnemosyne to fail as consequence. Reported as a dependency failure in #104441
Can we get this merged to master as well?

Ah, before this failed only on staging. I hoped this PR would be merged before the problem hit master, but it looks like it didn't make it. I think it would be fine to PR this change directly to master as well (but busy with other stuff myself right now, so go for it ;) ).

@FRidh
Copy link
Member

FRidh commented Nov 23, 2020

It's likely the version update will occur again soon. A potentially better fix here would be to fetch the sources from GitHub, so they match with the tests.

@raboof
Copy link
Member Author

raboof commented Nov 23, 2020

It's likely the version update will occur again soon.

Yeah, I think we've gone back-and-forth on this one before...

A potentially better fix here would be to fetch the sources from GitHub, so they match with the tests.

The sources on github do not contain tests at all. I guess that would sidestep the issue, yeah :). (see tarpas/pytest-testmon#158)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants