New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "python3Packages.pytest-testmon: 1.0.2 -> 1.0.3" #103958
Conversation
This reverts commit 0fc5e60. For some reason the v1.0.3 PyPI tarball ships with tests that expect pytest-testmon master instead of the v1.0.3 code (tarpas/pytest-testmon#158), causing these tests to fail against 1.0.3 itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good.
/cc @jonringer since it looks like you did the same before in 9f1bd6f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build tested on Python3.7 and 3.8. LGTM.
This is failing on
|
This is on its way into master, but was targeted for staging first. The title states this is a revert of the upgrade from 1.0.2 to 1.0.3. |
Ah, before this failed only on staging. I hoped this PR would be merged before the problem hit master, but it looks like it didn't make it. I think it would be fine to PR this change directly to master as well (but busy with other stuff myself right now, so go for it ;) ). |
It's likely the version update will occur again soon. A potentially better fix here would be to fetch the sources from GitHub, so they match with the tests. |
Yeah, I think we've gone back-and-forth on this one before...
The sources on github do not contain tests at all. I guess that would sidestep the issue, yeah :). (see tarpas/pytest-testmon#158) |
This reverts commit 0fc5e60.
For some reason the v1.0.3 PyPI tarball ships with tests that expect pytest-testmon master instead of the v1.0.3 code (tarpas/pytest-testmon#158), causing these tests to fail against 1.0.3 itself.
Alternative to #103786
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)