Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.gsconnect: 43 -> 44 #103666

Merged
merged 1 commit into from Nov 14, 2020
Merged

gnomeExtensions.gsconnect: 43 -> 44 #103666

merged 1 commit into from Nov 14, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 13, 2020 •
edited

Motivation for this change

Gnome 3.38 - #95248 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 13, 2020
@ofborg ofborg bot requested a review from etu November 13, 2020 08:27
jtojnar
jtojnar approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay https://github.com/andyholmes/gnome-shell-extension-gsconnect/releases/tag/v44

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Nov 13, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Nov 13, 2020 •
edited

Looks like installed tests still fail on LAN test but that is not a regression.

@doronbehar
Copy link
Contributor Author

Will merge once I see this working after I will use my system with this merged to my nixpkgs fork.

@doronbehar
Copy link
Contributor Author

Works.

@doronbehar doronbehar merged commit d67b00e into NixOS:master Nov 14, 2020
@doronbehar doronbehar deleted the pkg/gnomeExtensions/gsconnect branch November 14, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @jtojnar