Skip to content

vimPlugins.neuron-vim: 2020-10-29 -> 2020-11-11 #103645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2020
Merged

vimPlugins.neuron-vim: 2020-10-29 -> 2020-11-11 #103645

merged 2 commits into from
Nov 13, 2020
+179 −179

Conversation

wbadart
Copy link
Contributor

@wbadart wbadart commented Nov 12, 2020

Motivation for this change

There have been a couple important bug fixes pushed to
fiatjaf/neuron.vim in the last few days; just want to make sure they're
available via nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@wbadart wbadart requested a review from jonringer as a code owner November 12, 2020 21:50
@ofborg ofborg bot added 6.topic: vim 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 12, 2020
@jonringer
Copy link
Contributor

for vim plugins, please follow https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#updating-plugins-in-nixpkgs

Namely, there should be a single vimPlugins: update commit which will update all of the vim plugins to their latest

"Will Badart" added 2 commits November 13, 2020 11:48
vimPlugins: update

Verified

This commit was signed with the committer’s verified signature.
prusnak Pavol Rusnak
GPG key ID: 91F3B339B9A02A3D
Verified
Learn about vigilant mode
a8fb013
vimPlugins: resolve github repository redirects

Verified

This commit was signed with the committer’s verified signature.
prusnak Pavol Rusnak
GPG key ID: 91F3B339B9A02A3D
Verified
Learn about vigilant mode
6e9408f
@wbadart
Copy link
Contributor Author

wbadart commented Nov 13, 2020

Thanks for the feedback @jonringer. I'd been asked to touch up the commits created by update.py for #101385 so I thought I might have to do the same here. I've replaced my original commit with the untouched result of running update.py. You mentioned that there should be one commit, vimPlugins: update but the script also created 6e9408f; please let me know if I should delete that second commit.

@ofborg ofborg bot requested review from jagajaga and jorsn November 13, 2020 17:34
@jonringer
Copy link
Contributor

no, this is great!

@jonringer
Copy link
Contributor

but the script also created 6e9408f; please let me know if I should delete that second commit.

In most cases, will just make one. But it looks like someone redirected, and that should also be captured.

jonringer
jonringer approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103645 1

62 packages built:
  • vimPlugins.Coqtail
  • vimPlugins.YouCompleteMe
  • vimPlugins.barbar-nvim
  • vimPlugins.coc-explorer
  • vimPlugins.coc-markdownlint
  • vimPlugins.coc-nvim
  • vimPlugins.ctrlp-vim
  • vimPlugins.dart-vim-plugin
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-jedi
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.diagnostic-nvim
  • vimPlugins.dracula-vim
  • vimPlugins.fzf-vim
  • vimPlugins.hoon-vim
  • vimPlugins.indentLine
  • vimPlugins.lh-vim-lib
  • vimPlugins.lightline-vim
  • vimPlugins.ncm2-ultisnips
  • vimPlugins.neco-vim
  • vimPlugins.neoformat
  • vimPlugins.neomake
  • vimPlugins.neosnippet-snippets
  • vimPlugins.neoterm
  • vimPlugins.nerdtree-git-plugin
  • vimPlugins.neuron-vim
  • vimPlugins.nvim-treesitter
  • vimPlugins.oceanic-next
  • vimPlugins.open-browser-github-vim
  • vimPlugins.papercolor-theme
  • vimPlugins.skim-vim
  • vimPlugins.syntastic
  • vimPlugins.tagbar
  • vimPlugins.telescope-nvim
  • vimPlugins.ultisnips
  • vimPlugins.undotree
  • vimPlugins.vim-airline
  • vimPlugins.vim-airline-themes
  • vimPlugins.vim-bsv
  • vimPlugins.vim-clap
  • vimPlugins.vim-codefmt
  • vimPlugins.vim-exchange
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-gitgutter
  • vimPlugins.vim-go
  • vimPlugins.vim-graphql
  • vimPlugins.vim-jsx-pretty
  • vimPlugins.vim-lsc
  • vimPlugins.vim-mundo
  • vimPlugins.vim-pandoc
  • vimPlugins.vim-projectionist
  • vimPlugins.vim-snippets
  • vimPlugins.vim-tmux-navigator
  • vimPlugins.vim-trailing-whitespace
  • vimPlugins.vim-vsnip
  • vimPlugins.vim-vsnip-integ
  • vimPlugins.vimspector
  • vimPlugins.vimtex
  • vimPlugins.vista-vim
  • vimPlugins.wal-vim
  • vimPlugins.yats-vim

@jonringer jonringer merged commit f53113e into NixOS:master Nov 13, 2020
@wbadart wbadart deleted the update_neuron_vim branch November 13, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@jagajaga jagajaga

@jorsn jorsn

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wbadart @jonringer