Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-prefetch-github: 4.0.1 -> 4.0.2 #103655

Merged
merged 1 commit into from Nov 16, 2020

Conversation

sveitser
Copy link
Contributor

@sveitser sveitser commented Nov 13, 2020

Motivation for this change

Package Update. New version no longer uses pytest-black.

seppeljordan/nix-prefetch-github@3e1f3f9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sveitser
Copy link
Contributor Author

Result of nixpkgs-review pr 103655 1

3 packages built:
  • nix-prefetch-github (python38Packages.nix-prefetch-github)
  • pypi2nix
  • python37Packages.nix-prefetch-github

1 similar comment
@seppeljordan
Copy link
Contributor

Result of nixpkgs-review pr 103655 1

3 packages built:
  • nix-prefetch-github (python38Packages.nix-prefetch-github)
  • pypi2nix
  • python37Packages.nix-prefetch-github

Copy link
Contributor

@seppeljordan seppeljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I built the package via nix-prefetch-github and tested the executable which worked without issues.

@Ma27 Ma27 merged commit 307d471 into NixOS:master Nov 16, 2020
@sveitser sveitser deleted the update-nix-prefetch-github-4.0.2 branch November 16, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants