Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lombok: add bin output with lombok wrapper script #103646

Merged
merged 1 commit into from Jan 1, 2021
Merged

lombok: add bin output with lombok wrapper script #103646

merged 1 commit into from Jan 1, 2021

Conversation

rycee
Copy link
Member

@rycee rycee commented Nov 12, 2020

Motivation for this change

To provide a convenient way to run delombok.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from CrystalGamma November 12, 2020 22:19
SuperSandro2000
SuperSandro2000 reviewed Nov 24, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be jre enough?

@rycee
lombok: add bin output with lombok wrapper script
fd9b4ec 
The wrapper can be used, e.g., to run the delombok command.
@rycee
Copy link
Member Author

rycee commented Jan 1, 2021

Sorry about the delay. No, it needs to be jdk since the lombok tool uses tools.jar, which is only distributed in jdk.

@rycee rycee merged commit 9ce91be into NixOS:master Jan 1, 2021
@rycee rycee deleted the lombok-bin branch January 1, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@CrystalGamma CrystalGamma Awaiting requested review from CrystalGamma

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rycee @SuperSandro2000